fix: truncate time range to minutes

[nikhilsinhaparseable]

suppress seconds, milliseconds and nanoseconds
to make the start and end datetime till minutes

this solves the issue with the counts api with human time

Summary by CodeRabbit

• New Features
  • Time ranges parsed from human input are now automatically rounded down to the nearest minute for improved consistency.

[coderabbitai]

Walkthrough

The changes introduce a new public utility function, truncate_to_minute, in the time utilities module. This function takes a DateTime<Utc> and returns a new instance truncated to minute precision by zeroing out the seconds, milliseconds, and nanoseconds. The parse_human_time method in the TimeRange struct is updated to use this function, ensuring that both the start and end times parsed from human-readable input are aligned to minute boundaries. The import statements are expanded to include necessary traits for date and time manipulation.

Changes

File(s)	Change Summary
src/utils/time.rs	Added truncate_to_minute function; updated parse_human_time to truncate times to the minute; expanded chrono imports.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TimeRange
    participant Utils (truncate_to_minute)
    User->>TimeRange: parse_human_time(input)
    TimeRange->>TimeRange: Parse start/end DateTime<Utc>
    TimeRange->>Utils (truncate_to_minute): Truncate start to minute
    Utils (truncate_to_minute)-->>TimeRange: Return truncated start
    TimeRange->>Utils (truncate_to_minute): Truncate end to minute
    Utils (truncate_to_minute)-->>TimeRange: Return truncated end
    TimeRange-->>User: Return aligned time range

Loading

Suggested labels

for next release

Suggested reviewers

• de-sh

Poem

A minute’s precision, a hop in time,
With seconds now gone, the boundaries align.
Dates trimmed just right, for logic so neat,
The code now ensures all moments meet.
🕰️
—A rabbit, bounding through the fields of time

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95343bf and 2a8994b.

📒 Files selected for processing (1)

• src/utils/time.rs (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: coverage
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu

🔇 Additional comments (3)

src/utils/time.rs (3)

19-19: Import statement appropriately expanded.

The import statement now includes the necessary Datelike and TimeZone traits from the chrono crate, which are required for the new time truncation functionality.

---

81-96: Truncation logic correctly addresses the time precision issue.

The code properly implements the truncation of DateTime objects to minute precision by:

1. Making the variables mutable to allow for modification after initial parsing
2. Adding clear comments explaining the purpose of the truncation
3. Applying the truncation consistently to both start and end times

This change effectively resolves the issue with the counts API when using human-readable time inputs by ensuring consistent minute-level precision.

---

295-306: New utility function implementation is correct and reusable.

The truncate_to_minute function:

1. Properly extracts the date and time components to preserve
2. Creates a new DateTime with seconds set to 0
3. Uses appropriate error handling with an unwrap that's safe given the context

The implementation follows good practices by making the function public, allowing its reuse elsewhere in the codebase when minute-level precision is needed.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.