Skip to content

send analytics flag to analytics server #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025
Merged

send analytics flag to analytics server #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e980ff6
send analytics flag to analytics server
nikhilsinhaparseable Jun 20, 2025
1eddaa7
remove additional header, send_analytics in user_agent
nikhilsinhaparseable Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/about.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,15 @@ pub fn get_latest_release() -> &'static Option<LatestRelease> {
}

// User Agent for Download API call
// Format: Parseable/<UID>/<version>/<commit_hash> (<OS>; <Platform>)
pub fn user_agent(uid: &Ulid) -> String {
// Format: Parseable/<UID>/<version>/<commit_hash>/<send_analytics> (<OS>; <Platform>)
pub fn user_agent(uid: &Ulid, send_analytics: bool) -> String {
analytics::refresh_sys_info();
format!(
"Parseable/{}/{}/{} ({:?}; {})",
"Parseable/{}/{}/{}/{} ({:?}; {})",
uid,
current().released_version,
current().commit_hash,
send_analytics,
System::name().unwrap_or_default(),
platform()
)
Expand Down
6 changes: 4 additions & 2 deletions src/utils/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use std::time::Duration;
use anyhow::anyhow;
use chrono::{DateTime, Utc};

use crate::about;
use crate::{about, parseable::PARSEABLE};

use super::uid;

Expand All @@ -32,11 +32,13 @@ pub struct LatestRelease {
}

pub async fn get_latest(deployment_id: &uid::Uid) -> Result<LatestRelease, anyhow::Error> {
let send_analytics = PARSEABLE.options.send_analytics;
let agent = reqwest::ClientBuilder::new()
.user_agent(about::user_agent(deployment_id))
.user_agent(about::user_agent(deployment_id, send_analytics))
.timeout(Duration::from_secs(8))
.build()
.expect("client can be built on this system");

let json: serde_json::Value = agent
.get("https://download.parseable.io/latest-version")
.send()
Expand Down
Loading