Move authentication middleware to new scope #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested changes
Aug 6, 2022
| } | ||
|
|
||
| fn readiness_path() -> String { | ||
| format!("{}/readiness", base_path()) | ||
| "/readiness".to_string() |
| } | ||
|
|
||
| fn liveness_path() -> String { | ||
| format!("{}/liveness", base_path()) | ||
| "/liveness".to_string() |
| } | ||
|
|
||
| fn query_path() -> String { | ||
| format!("{}/query", base_path()) | ||
| "/query".to_string() |
trueleo
commented
Aug 6, 2022
| .service(ResourceFiles::new("/", generated)); | ||
| cfg.service( | ||
| // Base path "{url}/api/v1" | ||
| web::scope(&base_path()) |
There was a problem hiding this comment.
@nitisht base path is used inside this web::scope thus every path grouped underneath it will share same base url i.e /api/v1. I changed the related functions to not return full path.
There was a problem hiding this comment.
ah okay..we need to test all the APIs then, just to make sure nothing is broken
nitisht
approved these changes
Aug 6, 2022
|
Looking forward to it... Good Job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BasicAuth middleware was wrapped around entire application causing people to authenticate twice.
This PR fixes this by moving all endpoints under base path to a new scope then wrapping it in the BasicAuth middleware
Now the static files served under root path do not require authentication.