Skip to content

update: field names of attributes in each metric type #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

update: field names of attributes in each metric type #1456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/otel/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@
*
*/
use opentelemetry_proto::tonic::collector::metrics::v1::ExportMetricsServiceRequest;
use opentelemetry_proto::tonic::common::v1::KeyValue;
use opentelemetry_proto::tonic::metrics::v1::number_data_point::Value as NumberDataPointValue;
use opentelemetry_proto::tonic::metrics::v1::{
Exemplar, ExponentialHistogram, Gauge, Histogram, Metric, MetricsData, NumberDataPoint, Sum,
Summary, exemplar::Value as ExemplarValue, exponential_histogram_data_point::Buckets, metric,
};
use serde_json::{Map, Value};

use crate::otel::otel_utils::flatten_attributes;

use super::otel_utils::{
convert_epoch_nano_to_timestamp, insert_attributes, insert_number_if_some,
};
Expand Down Expand Up @@ -73,7 +76,7 @@ fn flatten_exemplar(exemplars: &[Exemplar]) -> Vec<Map<String, Value>> {
.iter()
.map(|exemplar| {
let mut exemplar_json = Map::new();
insert_attributes(&mut exemplar_json, &exemplar.filtered_attributes);
insert_exemplar_attributes(&mut exemplar_json, &exemplar.filtered_attributes);
exemplar_json.insert(
"exemplar_time_unix_nano".to_string(),
Value::String(convert_epoch_nano_to_timestamp(
Expand Down Expand Up @@ -120,7 +123,7 @@ fn flatten_number_data_points(data_points: &[NumberDataPoint]) -> Vec<Map<String
.iter()
.map(|data_point| {
let mut data_point_json = Map::new();
insert_attributes(&mut data_point_json, &data_point.attributes);
insert_metric_attributes(&mut data_point_json, &data_point.attributes);
data_point_json.insert(
"start_time_unix_nano".to_string(),
Value::String(convert_epoch_nano_to_timestamp(
Expand Down Expand Up @@ -218,7 +221,7 @@ fn flatten_histogram(histogram: &Histogram) -> Vec<Map<String, Value>> {
let mut data_points_json = Vec::new();
for data_point in &histogram.data_points {
let mut data_point_json = Map::new();
insert_attributes(&mut data_point_json, &data_point.attributes);
insert_metric_attributes(&mut data_point_json, &data_point.attributes);
data_point_json.insert(
"start_time_unix_nano".to_string(),
Value::String(convert_epoch_nano_to_timestamp(
Expand Down Expand Up @@ -315,7 +318,7 @@ fn flatten_exp_histogram(exp_histogram: &ExponentialHistogram) -> Vec<Map<String
let mut data_points_json = Vec::new();
for data_point in &exp_histogram.data_points {
let mut data_point_json = Map::new();
insert_attributes(&mut data_point_json, &data_point.attributes);
insert_metric_attributes(&mut data_point_json, &data_point.attributes);
data_point_json.insert(
"start_time_unix_nano".to_string(),
Value::String(convert_epoch_nano_to_timestamp(
Expand Down Expand Up @@ -384,7 +387,7 @@ fn flatten_summary(summary: &Summary) -> Vec<Map<String, Value>> {
let mut data_points_json = Vec::new();
for data_point in &summary.data_points {
let mut data_point_json = Map::new();
insert_attributes(&mut data_point_json, &data_point.attributes);
insert_metric_attributes(&mut data_point_json, &data_point.attributes);
data_point_json.insert(
"start_time_unix_nano".to_string(),
Value::String(convert_epoch_nano_to_timestamp(
Expand Down Expand Up @@ -647,3 +650,17 @@ fn flatten_data_point_flags(flags: u32) -> Map<String, Value> {
);
data_point_flags_json
}

fn insert_metric_attributes(map: &mut Map<String, Value>, attributes: &[KeyValue]) {
let attributes_json = flatten_attributes(attributes);
for (key, value) in attributes_json {
map.insert(format!("metric_{}", key), value);
}
}

fn insert_exemplar_attributes(map: &mut Map<String, Value>, attributes: &[KeyValue]) {
let attributes_json = flatten_attributes(attributes);
for (key, value) in attributes_json {
map.insert(format!("exemplar_{}", key), value);
}
}
Loading