Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws_profile to fetch credentials #380

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Apr 25, 2023

Fixes #372.

Description

Alternate method to fetch credentials on AWS.

AwsBuilder's with_profile builder method name is exposed as a configuration option with env P_S3_PROFILE_NAME. This option conflicts with P_S3_ACCESS_KEY and P_S3_SECRET_KEY


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 1b052c2 into parseablehq:main Apr 25, 2023
@trueleo trueleo deleted the aws_profile branch April 26, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add support for AWS temporary credentials within Parseable
2 participants