Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error on requests with root username #467

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Return error on requests with root username #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions server/src/handlers/http/rbac.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ pub async fn list_users() -> impl Responder {
pub async fn put_user(username: web::Path<String>) -> Result<impl Responder, RBACError> {
let username = username.into_inner();
validator::user_name(&username)?;
if username == CONFIG.parseable.username {
return Err(RBACError::BadUser);
}
let _ = UPDATE_LOCK.lock().await;
if Users.contains(&username) {
reset_password(username).await
Expand Down Expand Up @@ -81,6 +84,9 @@ pub async fn get_role(username: web::Path<String>) -> Result<impl Responder, RBA
// Handler for DELETE /api/v1/user/delete/{username}
pub async fn delete_user(username: web::Path<String>) -> Result<impl Responder, RBACError> {
let username = username.into_inner();
if username == CONFIG.parseable.username {
return Err(RBACError::BadUser);
}
let _ = UPDATE_LOCK.lock().await;
// fail this request if the user does not exists
if !Users.contains(&username) {
Expand Down Expand Up @@ -125,6 +131,9 @@ pub async fn put_role(
role: web::Json<serde_json::Value>,
) -> Result<String, RBACError> {
let username = username.into_inner();
if username == CONFIG.parseable.username {
return Err(RBACError::BadUser);
}
let role = role.into_inner();
let role: HashSet<DefaultPrivilege> = serde_json::from_value(role)?;
let role = role.into_iter().collect();
Expand Down Expand Up @@ -169,6 +178,8 @@ async fn put_metadata(metadata: &StorageMetadata) -> Result<(), ObjectStorageErr

#[derive(Debug, thiserror::Error)]
pub enum RBACError {
#[error("Request cannot be allowed for this user")]
BadUser,
#[error("User exists already")]
UserExists,
#[error("User does not exist")]
Expand All @@ -184,6 +195,7 @@ pub enum RBACError {
impl actix_web::ResponseError for RBACError {
fn status_code(&self) -> http::StatusCode {
match self {
Self::BadUser => StatusCode::BAD_REQUEST,
Self::UserExists => StatusCode::BAD_REQUEST,
Self::UserDoesNotExist => StatusCode::NOT_FOUND,
Self::SerdeError(_) => StatusCode::BAD_REQUEST,
Expand Down
Loading