Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectStorage: add AuthenticationError type #80

Merged
merged 1 commit into from
Aug 30, 2022
Merged

ObjectStorage: add AuthenticationError type #80

merged 1 commit into from
Aug 30, 2022

Conversation

123vivekr
Copy link
Contributor

Fixes #52 .

Description

Add ObjectStorage::AuthenticationError type to better signal error cause.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested a review from trueleo August 30, 2022 10:00
trueleo
trueleo approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@trueleo trueleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work 👍

@trueleo trueleo requested a review from nitisht August 30, 2022 10:44
@nitisht nitisht merged commit e960ceb into parseablehq:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueleo trueleo trueleo approved these changes

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve errors related to object storage authentication.
3 participants
@123vivekr @trueleo @nitisht