-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switched to tokio tasks #862
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@vishalkrishnads are you able to verify if the server is running and accepting events after this change? |
the server runs but isn't accepting requests. |
I see, so thats why tests are failing. Would you take a deeper look at what is going on? |
yes sure, i'll look into it. please give me a bit more time. |
Sure @vishalkrishnads . Please let us know if you need any help. |
Signed-off-by: Vishal <321vishalds@gmail.com>
this is kind of confusing. in this commit, all checks except the indentation one were passing. however, as I corrected it, the distributed docker compose test started failing. @nitisht any help would be appreciated. |
Fixes #652.
Description
Rewrote
object_store_sync()
&run_local_sync()
in server's sync.rs to use tokio tasks but with same function signature. Updated the invoking code to match.Rewrote
init_scheduler()
in server's storage/retention.rs to use tokio tasks but with same function signature. Updated the invoking code to match.This PR has: