Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to tokio tasks #862

Merged
merged 17 commits into from
Aug 10, 2024
Merged

switched to tokio tasks #862

merged 17 commits into from
Aug 10, 2024

Conversation

vishalkrishnads
Copy link
Contributor

@vishalkrishnads vishalkrishnads commented Jul 29, 2024

Fixes #652.

Description

  • Rewrote object_store_sync() & run_local_sync() in server's sync.rs to use tokio tasks but with same function signature. Updated the invoking code to match.

  • Rewrote init_scheduler() in server's storage/retention.rs to use tokio tasks but with same function signature. Updated the invoking code to match.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Copy link
Contributor

github-actions bot commented Jul 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@vishalkrishnads
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

nitisht added a commit to parseablehq/.github that referenced this pull request Jul 29, 2024
@nitisht
Copy link
Member

nitisht commented Aug 1, 2024

@vishalkrishnads are you able to verify if the server is running and accepting events after this change?

@vishalkrishnads
Copy link
Contributor Author

the server runs but isn't accepting requests.

@nitisht
Copy link
Member

nitisht commented Aug 1, 2024

the server runs but isn't accepting requests.

I see, so thats why tests are failing. Would you take a deeper look at what is going on?

@vishalkrishnads
Copy link
Contributor Author

vishalkrishnads commented Aug 1, 2024

yes sure, i'll look into it. please give me a bit more time.

@nitisht
Copy link
Member

nitisht commented Aug 1, 2024

yes sure, i'll look into it. please give me a bit more time.

Sure @vishalkrishnads . Please let us know if you need any help.

@vishalkrishnads
Copy link
Contributor Author

this is kind of confusing. in this commit, all checks except the indentation one were passing. however, as I corrected it, the distributed docker compose test started failing. @nitisht any help would be appreciated.

@nitisht nitisht merged commit fef8f6d into parseablehq:main Aug 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tokio async runtime instead of std::thread
2 participants