-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: adding azure blob as object store #946
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
f78794d
to
a578b11
Compare
@piyushsingariya for this to work, you need to implement all the methods defined under trait ObjectStorage |
I've reutilized the pre-written implementation of S3 for trait ObjectStorage, since S3 is initializing a client with I've achieved this via altering the previous S3 struct to be generic and to accept anything that implements the trait |
f2e8170
to
a578b11
Compare
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
@nikhilsinhaparseable It would be easier if you could checkout my pr in local with Do let me know what else needs to be fixed here, since I am really looking forward to getting this PR merged. |
@piyushsingariya we had a customer waiting for this so @nikhilsinhaparseable had to work on this here #955 . This effort looks like will take more time. I'd request you to close this PR. |
I'm quite disheartened by how this has turned out. I spent a few days working on my PR, hoping to contribute meaningfully, it sat unreviewed for a week. Though I understand the priority shift and urgency but this feels highly discouraging and doesn't align with the open-source spirit of collaboration. I truly hope this isn't indicative of how external contributions are generally handled. I hope this feedback helps improve the process for other contributors. Closing this PR. |
Thanks @piyushsingariya |
Fixes #687 .
Description
This PR aims to add support for Azure Blob Storage as Object Store in parseable.
The Solution/Changes implemented in this PR are as follows:
s3-store
Note
I've only started learning Rust less than a week ago, so I am unfamiliar with Rust ecosystem. Any guidance or feedback would be greatly appreciated as I work on this task.
This PR has: