Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update object_store #971

Merged
merged 3 commits into from
Oct 23, 2024
Merged

chore: update object_store #971

merged 3 commits into from
Oct 23, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Oct 22, 2024 •
edited
Loading

Ref #941

Description

Removes patch, updates to latest version of crate object_store.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as ready for review October 23, 2024 11:01
nitisht
nitisht reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update object_store crate also here to https://github.com/apache/arrow-rs/releases/tag/object_store_0.11.1

de-sh
de-sh commented Oct 23, 2024
View reviewed changes
Cargo.lock Show resolved Hide resolved
@nitisht nitisht merged commit ad977fd into parseablehq:main Oct 23, 2024
8 checks passed
@de-sh de-sh deleted the update-object-store branch October 24, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-sh @nitisht