upgrade to purescript 0.10 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintcius
commented
Dec 22, 2016
| @@ -60,14 +59,15 @@ instance functorTree :: Functor Tree where | |||
| map f (Tree a ts) = Tree (f a) (map f <$> ts) | |||
|
|
|||
| instance applyTree :: Apply Tree where | |||
| apply (Tree f tf) t@(Tree a ta) = Tree (f a) (map (f <$>) ta <> map (<*> t) tf) | |||
| apply (Tree f tf) t@(Tree a ta) = Tree (f a) (map (map f) ta <> map (applyFlipped t) tf) | |||
| where applyFlipped x y = apply y x | |||
There was a problem hiding this comment.
Couldn't find applyFlipped in standard libs
There was a problem hiding this comment.
Updated now - thanks @LiamGoodacre for pointing out the use of operator sections
rintcius
commented
Dec 22, 2016
| go n = do | ||
| sz <- Int.floor <<< Math.abs <$> arbitrary | ||
| Tree <$> arbitrary <*> replicateM sz (go (n / (sz + 1))) | ||
|
|
||
| replicateM n m | n < 1 = pure [] | ||
| | otherwise = sequence $ replicate n m |
There was a problem hiding this comment.
Couldn't find replicateM in standard libs any more
There was a problem hiding this comment.
I think you should be able to just do sequence (replicate sz (go (n / (sz + 1))). The replicate function for arrays will already deal with sz < 1. Alternatively there is replicateA from unfoldable.
rintcius
force-pushed
the
purescript-0.10
branch
from
3c976f8 to
34da6e3
Compare
rintcius
force-pushed
the
purescript-0.10
branch
from
34da6e3 to
c21589e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.json(split intobuildandtestscripts & removeddocgeneration which is usually not expected from libs any more)