bug fix when merging documents (affects when images are present in documents to be merged) #11
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'm running behind on reviewing PRs. Will try to get to it by Nov 1st. If it's still pending, please leave a comment again. Thank You! |
|
great work, this fixes the issue but the images wouldn't load, because it's not adding the actual images to # add the image to word/media folder
zos.put_next_entry("word/#{target_val}")
zos << zip_file.read("word/#{target_val}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10 ; sets
new_rel_nodeconsistently indef self.merge_documentsto avoid Nokogiri lowercasing the<Relationship>node that is created and attached