[Electron] Modem serial pausing before going into sleep with SLEEP_NETWORK_STANDBY #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t RTS line before sleeping to ask modem to pause transmission
…ature/electron/modem-sleep-rts
technobly
requested changes
Nov 29, 2016
| #if PLATFORM_ID==PLATFORM_ELECTRON_PRODUCTION | ||
| if (!network_sleep_flag(param)) { | ||
| // Pause the modem Serial | ||
| electronMDM.pause(); |
There was a problem hiding this comment.
This should be called via a wrapper function in cellular_hal
| #if PLATFORM_ID==PLATFORM_ELECTRON_PRODUCTION | ||
| if (!network_sleep_flag(param)) { | ||
| // Pause the modem Serial | ||
| electronMDM.resume(); |
There was a problem hiding this comment.
This should also be called via a wrapper function in cellular_hal
|
Since this does change the current behavior, we should add some Docs that explain what happens with received data now when the modem remains powered up while the system sleeps. The system has the ability to receive a message that was buffered by the modem during STM32 sleep. If too much data is received (how much?), what happens? (excessive data is lost or does it overwrite in circular fashion?). |
…r_hal moving to system-part3
|
Updated |
technobly
approved these changes
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With introduction of proper flow control handling via RTS line in PR #1140, modem should be unconditionally paused (by deasserting RTS line) before going into sleep with
SLEEP_NETWORK_STANDBY. This should allow Electron not to lose any URCs from the modem while it is sleeping.This PR includes a cucumber-based acceptance test which demonstrates how a sleepy Electron can receive a publish posted while it was sleeping:
$ cd user/tests/accept$ bundler install$ PLATFORM=electron ./run electron_modem_pauseIncludes PR #1097
Doneness:
Enhancements