Correctly process APPLICATION/SYSTEM DESCRIBE requests #1226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181
NOTE: Device currently receives incorrect DESCRIBE request with
flags=0x09
(see https://github.com/spark/firmware/blob/dfc5e68866cdd794d17ab51640ca565ae3a757ab/communication/src/protocol_defs.h#L91). The length of the request also seems to be wrong (judging by #1181), and instead of 9 bytes, the device receives 16 bytes, all extra bytes are 0x09:The PR accounts for this by assuming that the server actually requests
DESCRIBE_ALL (0x03)
, if describe flags byte>= DESCRIBE_ALL (0x03)
Doneness:
Bugfix
DESCRIBE
properly and return only one response, SYSTEM, APPLICATION, or COMBINED (ALL) describe message. Was sending separate SYSTEM and APPLICATION previously.