Ledger API #2660
Merged
Ledger API #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeuz
force-pushed
the
feature/ledger
branch
6 times, most recently
from
a6722ab
to
712b0e0
Compare
sergeuz
force-pushed
the
feature/ledger
branch
3 times, most recently
from
c5b99ab
to
9f396c3
Compare
sergeuz
force-pushed
the
feature/ledger
branch
5 times, most recently
from
88cdcef
to
b9e5bb1
Compare
|
Could you please add doxygen comments in the new wiring headers? The comments are automatically parsed by Workbench (VS Code) and appear as tips when implementing those classes/APIs in user apps. |
sergeuz
force-pushed
the
feature/ledger
branch
5 times, most recently
from
2246615
to
6009686
Compare
sergeuz
force-pushed
the
feature/ledger
branch
2 times, most recently
from
fece42c
to
fc48ccf
Compare
… be written in one go with the rest of the data
monkbroc
approved these changes
Jul 12, 2023
Merged
avtolstoy
added a commit
that referenced
this pull request
Aug 3, 2023
avtolstoy
added a commit
that referenced
this pull request
Aug 15, 2023
6 tasks
eberseth
reviewed
Sep 6, 2023
|
|
||
| spark::JSONWriter& spark::JSONWriter::value(unsigned long long val) { | ||
| writeSeparator(); | ||
| printf("%llu", val); |
There was a problem hiding this comment.
I don't think that our libc support this format type, %llu
eberseth
reviewed
Sep 6, 2023
| #ifndef Wiring_Ledger | ||
| #define Wiring_Ledger 0 | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Please add Variant and Map defines here as well in case we want to reuse them for external libraries.
#define Wiring_Variant 1
#define Wiring_Map 1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, superseded by #2715.
This is the first part of the Ledger functionality covering its storage logic and system/application APIs. Below are some links to simplify navigation in the new code:
Ledger
Auxillary classes
Outstanding issues
HAL_PLATFORM_ERROR_MESSAGES) on Tracker, which freed about 2K of flash space, to accommodate for other changes in this PR.rmrf()function added in this PR sometimes fails in load tests. The issue only affects theledger_purge*functions and may be specific to LittleFS.Testing
This PR adds some basic unit tests for the auxillary classes but the unit tests for the Ledger itself will be added in another PR with the synchronization logic. For now, the
wiring/ledgertest can be used to validate the basic logic of the Ledger.References