[test] resolve sleep20 test failures. #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuGuohui
commented
Jul 12, 2023
| // Make sure the modem is off first | ||
| Serial.println(" >> Powering off the modem..."); | ||
| #if HAL_PLATFORM_CELLULAR | ||
| Cellular.off(); | ||
| assertTrue(waitFor(Cellular.isOff, 60000)); | ||
| Serial.println(" >> Powering on the modem..."); | ||
| Cellular.on(); | ||
| if (i == 1) { |
There was a problem hiding this comment.
@avtolstoy Could you remind me why I was adding this loop and check? 😢
avtolstoy
approved these changes
Jul 19, 2023
| // Make sure the modem is off first | ||
| Serial.println(" >> Powering off the modem..."); | ||
| #if HAL_PLATFORM_CELLULAR | ||
| Cellular.off(); | ||
| assertTrue(waitFor(Cellular.isOff, 60000)); | ||
| Serial.println(" >> Powering on the modem..."); | ||
| Cellular.on(); | ||
| if (i == 1) { |
XuGuohui
force-pushed
the
fix/test_sleep20
branch
from
1d881a6
to
0963898
Compare
technobly
pushed a commit
that referenced
this pull request
Sep 18, 2023
[test] resolve sleep20 test failures.
technobly
pushed a commit
that referenced
this pull request
Sep 18, 2023
[test] resolve sleep20 test failures.
technobly
pushed a commit
that referenced
this pull request
Sep 19, 2023
[test] resolve sleep20 test failures.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
wiring/sleep20test failures:12_System_Sleep_With_Configuration_Object_Hibernate_Mode_Bypass_Network_Off_Execution_Time[Photon2]33_System_Sleep_With_Configuration_Object_Stop_Mode_Execution_Time[Argon/Photon2]34_System_Sleep_With_Configuration_Object_Ultra_Low_Power_Mode_Wakeup_Execution_Time[Argon/Photon2]35_System_Sleep_With_Configuration_Object_Network_Power_State_Consistent_Off[ Argon/Photon2]Completeness