Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ncp-client not waiting for modem ready on cold boot #2700

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

technobly
Copy link
Member

Problem

Solution

  • Add a retry scheme for CFUN=1,0 on initReady() only at this time.

Steps to Test

  • Cold boot the device and ensure any CFUN errors are handled, retried and the device boots successfully.
  • All integration tests should pass, especially the cold boot SLO test.

References

#2698


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added this to the 5.6.0 milestone Sep 22, 2023
@technobly technobly marked this pull request as ready for review September 22, 2023 23:43
@technobly technobly removed the 4.2.0 label Sep 26, 2023
@technobly technobly merged commit e140267 into develop Sep 26, 2023
13 checks passed
@technobly technobly deleted the fix/ncp-client branch September 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants