[msom] support 16MB GD flash. #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuGuohui
requested review from
avtolstoy,
technobly,
YutingYou and
scott-brust
avtolstoy
reviewed
Sep 28, 2023
XuGuohui
force-pushed
the
feature/rw-gd-16mb-otp
branch
from
5a63e55
to
adf0972
Compare
scott-brust
reviewed
Sep 28, 2023
scott-brust
reviewed
Oct 11, 2023
hal/src/rtl872x/exflash_hal.cpp
Outdated
| FLASH_WaitBusy(WAIT_WRITE_DONE); | ||
|
|
||
| // Write/Erase disable | ||
| FLASH_TxCmd(GENERIC_FLASH_CMD_WRDI, 0, nullptr); |
There was a problem hiding this comment.
Should we return SYSTEM_ERROR_NONE after this command?
It looks like execution will continue past the if (flash_init_para.FLASH_Id == FLASH_ID_GD) {} block and return ERROR NOT SUPPORTED?
hal/src/rtl872x/exflash_hal.cpp
Outdated
| } | ||
| }); | ||
| memcpy(ptr, addrBuf, 3); | ||
| memcpy(ptr + 3, buf, size); |
There was a problem hiding this comment.
We need to allocate an intermediate buffer because the address bytes + data need to be contiguous when sent with FLASH_TxCmd()?
Does the data need to be in heap / PSRAM or not?
scott-brust
reviewed
Oct 11, 2023
scott-brust
approved these changes
Oct 11, 2023
XuGuohui
force-pushed
the
feature/rw-gd-16mb-otp
branch
from
88f8358
to
83ba32e
Compare
XuGuohui
force-pushed
the
feature/rw-gd-16mb-otp
branch
from
83ba32e
to
357fb96
Compare
avtolstoy
approved these changes
Oct 12, 2023
| RTK_SPIC_DATA_WORD = 2 | ||
| }; | ||
|
|
||
| static void rtkSpiFlashSetDataReg(uint32_t index, uint32_t data, enum RtkSpicFlashDataWidth byteWidth) { |
There was a problem hiding this comment.
Nit: instead of static might be better to just move to an anonymous namespace.
technobly
pushed a commit
that referenced
this pull request
Nov 7, 2023
[msom] support 16MB GD flash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes.
This PR doesn't include the updating of memory map.
References
N/A
Completeness