[system] Fix bad int to bool conversion for clearCredentials #2736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It was reported that
WiFi.clearCredentials()
was returning a bad value for success in this Community post WiFi.clearCredentials() fails? on p2 @ 5.4.1.Rick dug into the issue and saw that there was an integer to bool conversion gone bad.
Solution
Added a comparison to zero with the
int clearConfiguration()
call so thatint() == 0
results in a booleantrue
innetwork_clear_credentials()
.Added comments for
network_clear_credentials()
usage.Steps to Test
Run this while credentials are set on the device.
References
Links to the Community, Docs, Other Issues, etc..
Completeness