Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process system tasks while cloud handshake is in progress #2745

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Feb 27, 2024

Problem

System tasks in SystemISRTaskQueue are not processed while the DTLS handshake or Hello request is in progress, which, among other things, prevents control requests from working. Story details: sc-125370.

Solution

Process the task queue while the handshake with the Cloud is in progress.

@sergeuz sergeuz marked this pull request as ready for review February 27, 2024 14:24
Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could process system event queue as well i.e. make spark_protocol_handshake() non-blocking, but for now this works as a workaround for USB requests and other things.

@sergeuz sergeuz merged commit 0920466 into develop Feb 28, 2024
13 checks passed
@sergeuz sergeuz deleted the comms_loop_idle_callback/sc-125370 branch February 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants