[rtl872x] fix wifi/ble coexistence issues; USB re-enum workarounds #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llation and tx start on full tx buffer
…ot ppp session resume in some cases
eberseth
reviewed
Mar 10, 2024
| @@ -229,7 +238,7 @@ class BleEventDispatcher { | |||
| void* allEvtQueue_; | |||
| void* ioEvtQueue_; | |||
| bool started_; | |||
| static constexpr uint8_t BLE_EVENT_THREAD_PRIORITY = OS_THREAD_PRIORITY_NETWORK; | |||
| static constexpr uint8_t BLE_EVENT_THREAD_PRIORITY = OS_THREAD_PRIORITY_NETWORK - 1; // IMPORTANT: below network for coexistence to work! | |||
There was a problem hiding this comment.
Any thread managing WiFi would effectively be higher priority than the BLE thread?
eberseth
reviewed
Mar 10, 2024
| if (r == GAP_CAUSE_SUCCESS) { | ||
| LOCAL_DEBUG("wait GAP_SCAN_STATE_IDLE"); | ||
| if (!waitState(BleGapDevState().scan(GAP_SCAN_STATE_IDLE))) { | ||
| // IMPORTANT: have to poll here, for some reason we may not get notified |
There was a problem hiding this comment.
Does this have anything to do with missing events/interrupts from the SDK?
eberseth
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO