Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inet_gethostbyname() behaviour and usage. #527

Merged
merged 1 commit into from
Aug 10, 2015
Merged

Fix inet_gethostbyname() behaviour and usage. #527

merged 1 commit into from
Aug 10, 2015

Conversation

andyw-lala
Copy link
Contributor

Use return value directly in system_cloud.cpp, instead of inferring error
from an IP address of 0.0.0.0.
Stop writing garbage into ip address in photon/inet_hal.cpp when the underlying
wiced call failed.
Use and pass on inet_gethostbyname() return value in spark_wiring_tcpclient.cpp

Use return value directly in system_cloud.cpp, instead of inferring error
from an IP address of 0.0.0.0.
Stop writing garbage into ip address in photon/inet_hal.cpp when the underlying
wiced call failed.
Use and pass on inet_gethostbyname() return value in spark_wiring_tcpclient.cpp
m-mcgowan added a commit that referenced this pull request Aug 10, 2015
Fix inet_gethostbyname() behaviour and usage.
@m-mcgowan m-mcgowan merged commit 4765b20 into particle-iot:develop Aug 10, 2015
@m-mcgowan
Copy link
Contributor

Thanks very much for this, and for the in-depth analysis on the forums.

@andyw-lala
Copy link
Contributor Author

Were you able to validate on the core ? I did not build/test for the core
(I wondered if that was where the ipaddr == 0.0.0.0 test came from...
On Aug 10, 2015 16:06, "Matthew McGowan" notifications@github.com wrote:

Thanks very much for this, and for the in-depth analysis on the forums.


Reply to this email directly or view it on GitHub
#527 (comment).

@m-mcgowan
Copy link
Contributor

I'll do a cursory check on the Core too to be sure, but the code looks good. The inet_gethostbyname should function in the same way on the Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants