DAC and PWM resolution #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the code. It looks great. |
|
Hello, when will this go live? looking forward to it? Is there something i can do to help? |
|
Tested on Photon
Tested on Core
|
technobly
added a commit
that referenced
this pull request
Dec 22, 2016
a892020 unifying Since x.x.x firmware version messages b153672 Since 0.7.0 -> Since 0.6.1 52a6313 Merge commit '60e0e09d54c2b5c1ebe875861da77a306d3c785b' into prerelease-dup 9dac290 More typos fixed 5295a53 corrected grammar (#524) 9f4b24b Spell check docs fcca5c6 occaisonal --> occasional 60e0e09 Reference documentation ef0dad7 Merge pull request #1190 from spark/feature/setup-button-mirror d2eb670 Merge pull request #1195 from spark/fix/revert_publish_api 05d0200 Merge branch 'develop' into feature/listen-timeout 2b43c71 grammatical error 878ba19 Revert Particle.publish() API changes; docs for WITH_ACK flag b7030c5 Update firmware.md d84a942 Add advanced process control fa03d96 Fix broken link on firmware page 03b8a78 Document Process::run 08047a0 EEPROM is borken on RPi 566a869 buttonMirror() documentation ea100c7 Support for `Serial1` is not complete 468b33d Raspberry Pi I2C firmware docs 32e5ba4 Remove software timers from RPi docs. 26d7251 Merge branch 'develop' into feature/conn_state_events e15b410 added v0.6.0 firmware notes 38614db adds Docs for set|getListenTimeout() 9949e2d adds usb-serial1 device tags eee29b2 cleanup serial2 and manual edits from last merge with conflicts 616330f Merge branch 'master' into prerelease 4590339 Update firmware docs to use device features 8e1149f Add device feature flags 62312f0 Add Raspberry Pi to firmware, tools and guides 7168402 Update firmware.md c93d248 Clarification of retained SRAM size 73f2e00 corrected typo 'sequencially' to 'sequentially' 648234c Merge pull request #468 from spark/feature/usb-docs-0.6.0 d3e5eba Reference docs 7794203 Merge branch 'master' into prerelease edcf989 adds link to freertos4core particle library 1ffdd80 time_changed system event dbc5d03 Time.isValid(), Particle.syncTimeDone()/syncTimePending()/timeSyncedLast() documentation c380dfd [optional] needs to include the optional comma too 6f5c96d Merge branch 'master' into prerelease 6cf14d1 Update firmware.md 6e6e216 Merge branch 'master' into prerelease f2cf630 adding notes for 0.5.1 and 0.5.2 firmware versions 6249120 adds reference.hbs back to firmware.md 6fa5464 ensure firmwareversions.js only loads on firmware.md aka firmware reference 4fc16b8 added CLI version, electron part 2/3 options and downgrading instructions ad530eb Separate Firmware Release and Formatting Tweaks aafbabe Create possibility for passing variables thorugh query params, for Firmware Releases 25cab35 Fixes typo 1aa4c18 Add B0-B5, C0-C5 to GPIO list in note for electron c857e8a Merge branch 'master' into prerelease dac4690 Keyboard and Mouse documentation 8d974bf Updated Serial documentation fd24a4d Merge pull request #467 from dougalcampbell/patch-1 4d75a59 Missing doc for TCPClient(buffer, len) 1b667e5 Use `hostname` instead of `URL` terminology d0e5903 Merge commit '568ceade3e1481cdb00dcdf51a97a737750a96bb' from firmware-docs into staging d49ac39 Merge branch 'master' into feature/tutorials e205803 Makes tests pass, fixing broken dashboard links 66a1955 Fix your product id link 81f7eb6 More Dashboard -> Console 266e459 fixed: markdown for threading docs 4f615c9 missing markdown for interrupts example 568cead Daylight Saving Time (DST) documentation a696d8a new analogRead() pinMode behavior for 0.5.3 system firmware aa2994a Fix description of sleep(pin, edge) 5c049dc fix typos b69e421 Typo in SoftAP example be62c64 Clarify behavior of 0 seconds in System.sleep() (#425) 838d6c7 missing parameters for printlnf() 7503310 relocated note 62acc8d missed # in condition 😊 f50a589 Update firmware.md 7bc380b Note WKP for deep sleep af77e5e Merge branch 'feature/reset-network-flag' into develop 405e9e9 Documentation fixes 0415ab4 API docs 0e0a691 Minor fixes 53f993b API docs for logging attributes 18483a2 Merge pull request #991 from spark/feature/dac-pwm-resolution 747f8d0 Merge pull request #997 from spark/feature/serial-config 26eaba8 Merge pull request #998 from spark/feature/logger_api b7f3081 Update flush() documentation af32b6b Store last reset reason and publish it to the cloud (#944) 08d2d42 USART configuration documentation 20ebf60 API docs 29e91a1 reduce datausage on reset/wakeup (#953) 6665b03 typo 4caa81c One carriage return isn't enough to make a new paragraph (#414) a4f05d6 Fix typo in handlebar if c790bcb Take out factory reset for anything but the Core d41c053 WIFI_CONNECT_NO_LISTEN actually is WIFI_CONNECT_SKIP_LISTEN 4db5752 Increase documented number of cloud functions and variables (#397) 80ff0e9 Add PRODUCT_ID to the firmware docs dc99c6e Reword cloud function #389 66f4acf analogWriteResolution documentation 3602095 Fix layout in Serial.begin() df96c32 Clarify include header for Serial2 761f7c4 explicitly show the particle.function protype 6667d16 add a single letter, whenver->whenever 79ea057 Wire.stretchClock() feature enabled by default for I2C Slave mode f3ad8b5 made firmware.md a symlnk on linux...didn't take on OS X git-subtree-dir: docs/reference git-subtree-split: a892020dc28f10d348c813f63e77099993ecf5f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
This PR implements configurable resolution for analogWrite (PWM and DAC).
New Wiring functions:
uint8_t analogWriteResolution(pin_t pin, uint8_t value);uint8_t analogWriteResolution(pin_t pin);uint32_t analogWriteMaxFrequency(pin_t pin);(see https://github.com/spark/firmware/blob/feature/dac-pwm-resolution/docs/reference/firmware.md for documentation)
DAC on Photon and Electron supports only 12-bit (default) or 8-bit resolution
Resolution also affects maximum frequency that can be used with
analogWrite()on PWM pins:Supported resolutions/maximum frequency per PWM pin group on Photon/P1/Electron:
Supported resolutions/maximum frequency per PWM pin group on Core:
Relevant tests:
wiring/no_fixturePWM*wiring/no_fixture_long_runningPWM_CompherensiveResolutionFrequencywiring/adc_dacDoneness: