Skip to content

Commit

Permalink
fixes tinker incompatibility with Device OS >=0.8.0-rc.1 on Photon/P1…
Browse files Browse the repository at this point in the history
… [ch19008]
  • Loading branch information
technobly committed Dec 19, 2018
1 parent a1bb818 commit 8a46b84
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions accept/features/binary_inspect.feature
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,22 @@ Feature: binary inspect
Then the stdout should not contain "monolithic"

Scenario: Detailed test Photon tinker app binary
Given I run particle "binary inspect photon_tinker.bin"
Given I run particle "binary inspect tinker-0.4.5-photon.bin"
Then the stdout should contain:
"""
photon_tinker.bin
CRC is ok (ba4f59ab)
tinker-0.4.5-photon.bin
CRC is ok (4a738441)
Compiled for photon
This is an application module number 1 at version 2
It depends on a system module number 2 at version 1
"""

Scenario: Detailed test P1 tinker app binary
Given I run particle "binary inspect p1_tinker.bin"
Given I run particle "binary inspect tinker-0.4.5-p1.bin"
Then the stdout should contain:
"""
p1_tinker.bin
CRC is ok (61972e4d)
tinker-0.4.5-p1.bin
CRC is ok (70e7c48c)
Compiled for p1
This is an application module number 1 at version 2
It depends on a system module number 2 at version 3
Expand Down
Binary file removed assets/binaries/p1_tinker.bin
Binary file not shown.
Binary file removed assets/binaries/photon_tinker.bin
Binary file not shown.
Binary file added assets/binaries/tinker-0.4.5-p1.bin
Binary file not shown.
Binary file added assets/binaries/tinker-0.4.5-photon.bin
Binary file not shown.
4 changes: 2 additions & 2 deletions src/lib/deviceSpecs/specifications.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const specs = {
alt: '0'
},
knownApps: {
'tinker': 'photon_tinker.bin',
'tinker': 'tinker-0.4.5-photon.bin',
'doctor': 'photon_doctor.bin',
'voodoo': 'voodoospark.bin'
},
Expand Down Expand Up @@ -186,7 +186,7 @@ const specs = {
alt: '0'
},
knownApps: {
'tinker': 'p1_tinker.bin',
'tinker': 'tinker-0.4.5-p1.bin',
'doctor': 'p1_doctor.bin',
'voodoo': 'voodoospark.bin'
},
Expand Down

0 comments on commit 8a46b84

Please sign in to comment.