Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

particle-cli update/install fails with node 12. Node-gyp need to be updated #508

Closed
junior opened this issue Aug 7, 2019 · 4 comments
Closed

particle-cli update/install fails with node 12. Node-gyp need to be updated #508

junior opened this issue Aug 7, 2019 · 4 comments

Comments

@junior
Copy link

junior commented Aug 7, 2019

Currently the update and install fails if used the current version of node (12).

node-gyp need to be updated to work with node 12 and its dependencies like NAN that needs to be 2.3+.
@busticated
Copy link
Contributor

busticated commented Aug 7, 2019 •
edited
Loading

yep, it's on my list here. some background 👉 #486

@junior
Copy link
Author

junior commented Aug 7, 2019

Just updating the node port would be enough?

@nikeee
Copy link
Contributor

nikeee commented Sep 8, 2019

I think this was fixed in #509.

@busticated busticated mentioned this issue Dec 4, 2019
Merged
6 tasks
@busticated
Copy link
Contributor

this should be fixed as of #509

i've released 2.0.0-rc.0 based on the feature/v2 branch and associated PR #537

it adds official support for node@12 and drops support for node@6

you can install it by running npm i particle-cli@next

i'm closing this out but feel free to chime in over in the aforementioned PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@busticated @junior @nikeee