Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/v2 #537

Merged
merged 12 commits into from
Dec 11, 2019
Merged

feature/v2 #537

merged 12 commits into from
Dec 11, 2019

Conversation

busticated
Copy link
Contributor

@busticated busticated commented Dec 4, 2019

Description

Adding official Node v12 support, dropping Node v6 support (hence the major bump)

How to Test

Install and run Node v12 - fwiw, here's what i do:

>>brew install node@12
>>brew unlink node@8 && brew link node@12 --overwrite --force

...and verify your versions:

>>node -v
v12.13.1
>>npm -v
6.12.1

...then reinstall local dependencies

>>npm run reinstall

...and confirm no changes are made to npm-shrinkwrap.json

With that all in place, connect your device and run the end-to-end tests

>>npm test

Lastly, broadly try commands.

Related Issues / Discussions

#508
#512

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@busticated busticated requested a review from wraithan December 4, 2019 01:01
Copy link
Contributor

@wraithan wraithan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, ran it locally to monitor a serial device and did some other usb/serial interactions. I double check the log output of npm ci and didn't see it building serialport (or any other native code for that matter) it runs the rebuild for it but that returns immediately without doing any compilation.

@busticated
Copy link
Contributor Author

i've published a pre-release version on npm.

you can install it by running npm i particle-cli@next 👍

@busticated busticated merged commit e29c21b into master Dec 11, 2019
@busticated busticated deleted the feature/v2 branch December 11, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants