-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/v2 #537
feature/v2 #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, ran it locally to monitor a serial device and did some other usb/serial interactions. I double check the log output of npm ci
and didn't see it building serialport
(or any other native code for that matter) it runs the rebuild for it but that returns immediately without doing any compilation.
cbbdac2
to
4162beb
Compare
ac11a2b
to
3330362
Compare
i've published a pre-release version on npm. you can install it by running |
Description
Adding official Node v12 support, dropping Node v6 support (hence the major bump)
How to Test
Install and run Node v12 - fwiw, here's what i do:
...and verify your versions:
...then reinstall local dependencies
...and confirm no changes are made to
npm-shrinkwrap.json
With that all in place, connect your device and run the end-to-end tests
Lastly, broadly try commands.
Related Issues / Discussions
#508
#512
Completeness