device: add duo support #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| addressOffset: 384, | ||
| portOffset: 450 | ||
| }, | ||
| udpServerKey: { |
There was a problem hiding this comment.
We should probably check, but I doubt they are supporting the UDP protocol.
There was a problem hiding this comment.
correct, as far as I know just TCP for the Duo
There was a problem hiding this comment.
Can we just remove them? Will it cause any issues when running commands?
There was a problem hiding this comment.
You can remove them, yes. The Core does not have them either.
There was a problem hiding this comment.
@brycekahle, removed the UDP stuff.
- DFU works (tested sys1, sys2, user, factory) - Serial works (wifi, inspect, identify) - Not sure about the public/private keys address location though - serialNumber: 'RedBear_Duo' is not verfied as this shows up in linux but should be correct based on https://github.com/redbear/firmware/blob/duo/bootloader/src/stm32f2xx/usbd_desc.c Signed-off-by: Kenneth Lim <kennethlimcp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenneth Lim kennethlimcp@gmail.com