Set up wifi using credentials from a JSON file #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-moraru
approved these changes
Mar 21, 2018
src/cli/serial.js
Outdated
| } | ||
| }, | ||
| examples: { | ||
| '$0 $command': 'Prompt for Wi-Fi credentials and send them to device connected over serial', |
src/cli/serial.js
Outdated
| }, | ||
| examples: { | ||
| '$0 $command': 'Prompt for Wi-Fi credentials and send them to device connected over serial', | ||
| '$0 $command --file credentials.json': 'Read Wi-Fi credentials from credentials.json and send them to device connected over serial' |
| let security = 3; | ||
| if (securityType.indexOf('WPA2') >= 0 && securityType.indexOf('802.1x') >= 0) { |
There was a problem hiding this comment.
Your code looks good and works, this is just a random idea.
Not sure 100% if it works, but it looks kinda cool
if (opts.security) {
const s = opts.security.reduce((acc, current) => { return Object.assign({}, acc, { [current]: true })}, {});
security = security || (s['WPA2'] && s['802.1x'] && 5);
isEnterprise = security || isEnterprise;
security = security || (s['WPA'] && s['802.1x'] && 4);
isEnterprise = security || isEnterprise;
security = security || (s['WEP'] && 3);
isEnterprise = security || isEnterprise;
}
There was a problem hiding this comment.
This is not my code. It doesn't have any tests so I'd rather leave it alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404