bugfix/project-create-args #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busticated
commented
Jun 22, 2018
| const site = new CLIProjectInitCommandSite({ | ||
| directory: argv.params.dir, | ||
| name: argv.name | ||
| }); |
There was a problem hiding this comment.
some context: arg handling has been broken for a while it seems (since 9ea72b0#diff-dc2a887cded43f37a650c27b9b32b44dR35). dropping process.cwd() here has no end-user impact since it was redundant - we call it again here:
particle-cli/src/cli/project_init.js
Line 83 in efac328
so overall this seems pretty low-risk 👍
monkbroc
approved these changes
Jun 25, 2018
busticated
force-pushed
the
bugfix/project-create-args
branch
from
efac328 to
5b6d1b4
Compare
busticated
force-pushed
the
bugfix/project-create-args
branch
from
5b6d1b4 to
e9c4176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/particle/story/16775/dir-parameter-and-name-option-are-ignored-in-project-create-command