Update for Device OS for 1.2.1 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
technobly
commented
Jul 11, 2019
•
technobly
commented
- Updated binaries for Device OS 1.2.1
- Removed Ascender mechanism for updating bootloaders and replaced with shiny new 🌟 feature implemented in Device OS PR 1788 that allows us to flash the bootloader via DFU with special sequence.
- Tested on all 9 modular platforms
technobly
force-pushed
the
feature/deviceos-121
branch
2 times, most recently
from
590be6e to
915e6d2
Compare
busticated
approved these changes
Jul 11, 2019
technobly
force-pushed
the
feature/deviceos-121
branch
from
915e6d2 to
d227c71
Compare
m-mcgowan
approved these changes
Jul 11, 2019
| address: '0x80289000', | ||
| alt: '2' | ||
| }, | ||
| otaFlag: { |
There was a problem hiding this comment.
This might seem like a nit-pick, but repeated data like this is possibly best factored out into an instance that is reused.
| systemFirmwareOne: 'boron-system-part1@1.1.1.bin' | ||
| systemFirmwareOne: 'boron-system-part1@1.2.1.bin', | ||
| otaRegion: 'boron-bootloader@1.2.1.bin', | ||
| otaFlag: 'ota-flag-a5.bin' |
There was a problem hiding this comment.
This was smart! And avoids lots of unnecessary file cleanup logic! 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.