Allow list filters to work with usb list command #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busticated
suggested changes
Apr 13, 2020
|
Would be good to add some notes in this PR for how this new feature works. Or a link to a Docs PR. |
… command. Test are required.
…tests for those filters. Adding unit tests and e2e tests to both Cloud List and USB List functionality.
JamesHagerman
force-pushed
the
ch51710/allow-list-filters-to-work-with-usb-list
branch
from
2c1cc51 to
de0b32d
Compare
JamesHagerman
deleted the
ch51710/allow-list-filters-to-work-with-usb-list
branch
|
@technobly For the record, usage is documented in the output of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/particle/story/51710