-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate particle-cli to CircleCI #619
Migrate particle-cli to CircleCI #619
Conversation
See https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions for a list of supported xcode versions.
This was included in the .travis.yml
@busticated I have the unit tests running for multiple versions of node on both MacOS and Linux. The node 8 tests are failing due to the following error:
Before I dig into this, want to confirm that we still want to test on node 8. If yes, any suggestions on how to get the usb dependency to installed for node8? |
6a799b1
to
d0629dc
Compare
7b49b67
to
0c16c50
Compare
7101cf6
to
4a8c8af
Compare
fdccc81
to
0318af1
Compare
731635a
to
6fff1bc
Compare
I took a stab at running the tests on Windows as well. I skipped running the e2e tests since the failures there were harder to debug. The main source of failures I'm seeing is that we're now running several e2e tests in parallel and they sometimes conflict with each other, for example removing a device from the product in one job but expecting it to be in the product in another job. It might be best to run e2e tests in sequence but then the tests will be super slow. |
This unit test frequently fails so I'd advocate removing it
|
004356f
to
de6b48b
Compare
de6b48b
to
7c9dda9
Compare
Checking to see if those are still running successfully.
This test often encounters a timeout before completing. Commenting out until we have time to address why the test is taking so long.
5b3e1c0
to
ce8f5bd
Compare
I'm glad to see all the ✔️ on the CircleCI checks! Thanks for the work here, Debbie! Mirande, I put the E2E tests in a sequence to avoid false failures when tests for the same feature ran in parallel. |
We are no longer using this.
Always a good idea to authenticate when pulling from DockerHub, otherwise you might get rate limited.
Will publish if this is a tagged release. Not sure how to test this given this is a public npm repository.
Need to DRY up this config file a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Mirande, does the CI setup meet your expectations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - thanks y'all 🙏 👍
Story details: https://app.shortcut.com/particle/story/102023
Migrate CI from Travis to CircleCI.
Notable changes/notes