-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sc-117249/add-a-sso-flag-to-cli-login #637
feature/sc-117249/add-a-sso-flag-to-cli-login #637
Conversation
Add Node18 on CircleCI tests
…alport dependency
Great work @hugomontero 🎉 Is that expected?
Edit |
Yeah that's expected, the code still alive and the only way your code expires is:
I have some failure case handling but are more like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interactions with Okta look good, but the UI code needs a bit of tweaking.
Description
This PR will add the ability to login over sso
How to Test
git pull && git checkout feature/sc-117249/add-a-sso-flag-to-cli-login
npm run reinstall
npm test
npm start -- login --sso
Outcome
Related Issues / Discussions
Story details : sc-117249
Completeness