Use the DeviceOS versions endpoints when compiling #765
Conversation
|
@keeramis do you have any insight into why the e2e tests are failing? This seemed to start after the last merge into |
| @@ -154,6 +154,17 @@ module.exports = class ParticleApi { | |||
| ); | |||
| } | |||
|
|
|||
| listDeviceOsVersions(platformId, internalVersion, perPage=100){ | |||
There was a problem hiding this comment.
Since we have different params I think might worth to transform it like {platformId, internalVersion, perPage=100} = {} unless we can't use the params separately like just send internalVersion without platformId
There was a problem hiding this comment.
Good point. In this instance only platformId parameter is being used. I kept the positional arguments instead of making them named (with {}) to keep the function signature match the others.
|
@suda It was failing to login. Let's see if rerunning helps. I see that you are doing that already |
In this specific case just needed to re-run tests to make it all pass 😄 |
suda
force-pushed
the
feature/sc-129513/use-the-deviceos-versions-endpoints-when
branch
from
dbd20b8 to
f006e9a
Compare
suda
deleted the
feature/sc-129513/use-the-deviceos-versions-endpoints-when
branch
Story details: https://app.shortcut.com/particle/story/129513