Skip adding protected devices to non-protection products #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title says.
The
api-service
provides a list of device identifiers calledprotectedDeviceIds
. This list includes the IDs of protected devices that are being attempted to be added to non-protected products. These device IDs have already been filtered out by theapi-service
to prevent them from being added to the product. Inparticle-cli
, we notify the user that these device IDs are being skipped.How to Test
Refer to the testing instructions here - https://github.com/particle-iot-inc/api-service/pull/1564
Related Issues / Discussions
https://github.com/particle-iot-inc/api-service/pull/1564
https://app.shortcut.com/particle/story/129604/don-t-allow-moving-a-protected-device-to-a-non-protected-product
Completeness