Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell completions #23

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

Ulexus
Copy link
Contributor

@Ulexus Ulexus commented May 27, 2020

Adds completion command for all cobra-supported shells.

Fixes #21

Signed-off-by: Seán C McCord ulexus@gmail.com

What? (description)

Adds autogenerated shell completions via the completion subcommand.

Why? (reasoning)

Issue #21

Screenshots (if applicable)

GitHub Issue (if applicable)

[closes #21]

Acceptance

Check your PR for the following:

  • you included tests
  • you linted your code
  • your PR has only one commit (interactive rebase!)
  • your commit message follows Conventional Commit format
  • you are not reducing the total test coverage

Adds completion command for all cobra-supported shells.

Fixes particledecay#21

Signed-off-by: Seán C McCord <ulexus@gmail.com>
@Ulexus
Copy link
Contributor Author

Ulexus commented May 28, 2020

@particledecay Do you have idea what is going on with this codeclimate issue? I haven't even touched add.go.

@Ulexus Ulexus marked this pull request as ready for review May 28, 2020 02:10
@Ulexus Ulexus requested a review from particledecay as a code owner May 28, 2020 02:10
@particledecay
Copy link
Owner

@Ulexus sorry, been busy lately. This is why it's not passing:

Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag

That secret is there, in the upstream repo... I'm guessing since that won't trickle down to your fork, it doesn't work. Looks like I might not be able to rely on diff-coverage and test-coverage to succeed from forks 😕

Copy link
Owner

@particledecay particledecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @Ulexus so much!

@particledecay particledecay merged commit 9d7c653 into particledecay:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shell autocompletion
2 participants