do not remove shared users #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
particledecay
force-pushed
the
bug_rm_shared_user
branch
4 times, most recently
from
f2c93be to
a6804cc
Compare
AuthInfo users that were being shared by other contexts would still be removed if a context was removed that was using it. This fixes that behavior by only removing an AuthInfo if no other contexts are currently using it.
particledecay
force-pushed
the
bug_rm_shared_user
branch
from
a6804cc to
e62f619
Compare
|
Code Climate has analyzed commit e62f619 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.5% (0.4% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? (description)
Only remove AuthInfos if they don't appear in any other Context.
Why? (reasoning)
AuthInfo users that were being shared by other Contexts would still be
removed if a Context was removed that was using it. This fixes that
behavior by only removing an AuthInfo if no other Contexts are currently
using it.
GitHub Issue (if applicable)
[closes #44]
Acceptance
Check your PR for the following: