Ports EXCLUDE to resolved plan #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (b0839c7) but now fail: 0 Number failing in Base (b0839c7) but now pass: 0 |
alancai98
reviewed
Oct 9, 2023
partiql-planner/src/main/kotlin/org/partiql/planner/typer/PlanTyper.kt
Outdated
Show resolved
Hide resolved
rchowell
force-pushed
the
planner-exclude
branch
from
ad2f947 to
c249729
Compare
alancai98
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
🚢 . looks to have a ktlint failure: https://github.com/partiql/partiql-lang-kotlin/actions/runs/6462383725/job/17543877945?pr=1243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
#1226
Description
This is a port of Alan's work on EXCLUDE (#1226) to the resolve logical plan.
Other Information
This passes all existing EXCLUDES tests.
Any backward-incompatible changes? [YES/NO]
No
Any new external dependencies? [YES/NO]
No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.