Optimize LIKE pattern compilation and make LIKE pattern compilation interruptible. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In two ways: - Change fold/union operations to accumulate to a single list. - Replace *ordered* sets and maps to hash sets and maps. This results in a > 10x improvement in compiling large like patterns (i.e. 1000 characters and up).
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
============================================
+ Coverage 82.44% 82.45% +0.01%
Complexity 1202 1202
============================================
Files 155 155
Lines 9283 9293 +10
Branches 1522 1524 +2
============================================
+ Hits 7653 7663 +10
- Misses 1175 1176 +1
+ Partials 455 454 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dlurton
commented
Sep 15, 2020
Comment on lines
+416
to
+422
| nfaStates.forEach { state -> | ||
| addAll(state.getOutgoingStates(it)) | ||
|
|
||
| if (Thread.interrupted()) { | ||
| throw InterruptedException() | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the change in this PR that results in the biggest performance improvement. The other stuff is incremental.
alancai98
reviewed
Sep 15, 2020
therapon
reviewed
Sep 15, 2020
jobarr-amzn
reviewed
Sep 15, 2020
dlurton
force-pushed
the
optimize-like-final
branch
from
4954e9c to
d53ef3d
Compare
alancai98
approved these changes
Sep 16, 2020
therapon
approved these changes
Sep 19, 2020
therapon
approved these changes
Sep 19, 2020
|
Superseded by #286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
masterthis expression takes on average 37 seconds to compile:'foo' like '%<n>%'(<n>is 1500!characters)With this change, on average it takes ~2.6 seconds to compile.
This is still an order of magnitude slower than it really needs be, but is (comparatively speaking) much better and all that I can do in the short term.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.