Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SIZE function work with s-expressions. #379

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Make SIZE function work with s-expressions. #379

merged 1 commit into from
Mar 18, 2021

Conversation

dlurton
Copy link
Member

@dlurton dlurton commented Mar 17, 2021

Implements #30

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #379 (69d647e) into master (7f76f53) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #379      +/-   ##
============================================
+ Coverage     81.63%   81.65%   +0.01%     
- Complexity     1307     1308       +1     
============================================
  Files           167      167              
  Lines         10222    10222              
  Branches       1671     1671              
============================================
+ Hits           8345     8347       +2     
+ Misses         1343     1342       -1     
+ Partials        534      533       -1     
Flag Coverage Δ Complexity Δ
CLI 17.62% <ø> (ø) 0.00 <ø> (ø)
EXAMPLES 74.85% <ø> (ø) 0.00 <ø> (ø)
LANG 84.19% <ø> (+0.02%) 0.00 <ø> (ø)
PTS 100.00% <ø> (ø) 0.00 <ø> (ø)
TEST_SCRIPT 79.68% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...org/partiql/lang/eval/builtins/SizeExprFunction.kt 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ng/src/org/partiql/lang/eval/EvaluatingCompiler.kt 83.37% <0.00%> (+0.27%) 158.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f76f53...69d647e. Read the comment docs.

@dlurton dlurton merged commit f6dd883 into master Mar 18, 2021
@dlurton dlurton deleted the size-sexp branch May 6, 2021 21:11
@dlurton dlurton added this to the v0.3.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants