-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OUTER set operators to parser and type domain #678
Conversation
Codecov Report
@@ Coverage Diff @@
## main #678 +/- ##
============================================
+ Coverage 79.61% 80.40% +0.79%
- Complexity 2350 2558 +208
============================================
Files 236 240 +4
Lines 19358 21003 +1645
Branches 3768 4248 +480
============================================
+ Hits 15411 16888 +1477
- Misses 2660 2793 +133
- Partials 1287 1322 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the modeling of OUTER
in set operators and not needing to support OUTER
in the older AST versions. Also noticed that specifying DISTINCT
following the set operator results in a parser error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more tests and addressing the feedback. Left a comment about some operators missing from the precedence map and some rewritten SqlParserTest
test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: R. C. Howell <howero@amazon.com>
Issue #, if available:
Part 2 of — #184
Description of changes:
These changes add the OUTER set operators defined in RFC-0007 to the type universe, lexer, and parser.
Have you updated the
Unreleased
section ofCHANGELOG.md
with your changes? (y/n), If not, please explain why: No, N/ADoes your PR include any backward-incompatible changes? (y/n), if yes, please explain the reason. In addition, please
also mention any other alternatives you've considered and the reason they've been discarded?: N
Does your PR introduce a new external dependency? (y/n), if yes, please explain the reason. In addition, please
also mention any other alternatives you've considered and the reason they've been discarded?: N
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.