-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function call lowering and evaluation for selected built-ins #264
Conversation
Codecov ReportBase: 89.09% // Head: 88.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 89.09% 88.94% -0.16%
==========================================
Files 38 39 +1
Lines 8471 8934 +463
==========================================
+ Hits 7547 7946 +399
- Misses 924 988 +64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It seems that this PR has made too many long-named tests succeed and the length of the diff list has broken the workflow's auto-commenting 😀 I've copied the markdown from the workflow output below Conformance comparison report
Number passing in both: 1384 Number failing in both: 429 Number passing in main but now fail: 0 Number failing in main but now pass: 752 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
Updated for latest run: Conformance comparison report
Number passing in both: 1384 Number failing in both: 418 Number passing in main but now fail: 0 Number failing in main but now pass: 763 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
Perhaps this could be fixed by shortening some of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nice conformance improvements! Left some comments related to MISSING
propagation
Co-authored-by: Alan Cai <caialan@amazon.com>
492a2aa
to
09c855f
Compare
Function call lowering and evaluation for selected built-ins:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.