Fix clippy warnings/errors #436
Merged
GitHub Actions / clippy
succeeded
Oct 24, 2023 in 0s
clippy
3 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 3 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 134 in partiql-eval/src/eval/expr/path.rs
github-actions / clippy
usage of `Iterator::fold` on a type that implements `Try`
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:132:18
|
132 | .fold(Some(owned), |v, path| {
| __________________^
133 | | v.and_then(|v| path.take_val(v, bindings, ctx))
134 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(owned, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
Check warning on line 127 in partiql-eval/src/eval/expr/path.rs
github-actions / clippy
usage of `Iterator::fold` on a type that implements `Try`
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:125:18
|
125 | .fold(Some(borrowed), |v, path| {
| __________________^
126 | | v.and_then(|v| path.get_val(v, bindings, ctx))
127 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(borrowed, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
github-actions / clippy
redundant pattern matching, consider using `is_some()`
warning: redundant pattern matching, consider using `is_some()`
--> /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-dfb8c13a5c10ee4a/out/partiql.rs:47881:25
|
47881 | let recursive = matches!(rec, Some(_));
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rec.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
Loading