-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parsing of EXCLUDE
#480
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 81.05% 80.98% -0.08%
==========================================
Files 68 68
Lines 18608 18680 +72
Branches 18608 18680 +72
==========================================
+ Hits 15083 15128 +45
- Misses 3082 3109 +27
Partials 443 443 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (3ca67b7) but now fail: 0 Number failing in Base (3ca67b7) but now pass: 0 |
7999c0a
to
3c07a7e
Compare
/// A "step" within a path expression; that is the components of the expression following the root. | ||
#[derive(Visit, Clone, Debug, PartialEq)] | ||
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
pub enum ExcludePathStep { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that the naming of the enum variants are the same as PathStep
Co-authored-by: Alan Cai <caialan@amazon.com>
For the
EXCLUDE
clause, implements:Cf. partiql/partiql-docs#51
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.