Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modeling of Literals in the AST remove ambiguity #517

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Nov 16, 2024

Change parsing and AST-modeling of literals to not share AST structures with non-scalar expressions.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 89.07563% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (75ffa06) to head (da6d69d).
Report is 1 commits behind head on dev-ion-doc.

Files with missing lines Patch % Lines
partiql-parser/src/parse/parse_util.rs 83.67% 5 Missing and 3 partials ⚠️
partiql-ast/src/ast.rs 0.00% 4 Missing ⚠️
partiql-logical-planner/src/lower.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           dev-ion-doc     #517      +/-   ##
===============================================
+ Coverage        80.70%   80.75%   +0.04%     
===============================================
  Files               88       88              
  Lines            19409    19483      +74     
  Branches         19409    19483      +74     
===============================================
+ Hits             15665    15734      +69     
- Misses            3324     3326       +2     
- Partials           420      423       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Conformance comparison report

Base (75ffa06) 341e05f +/-
% Passing 86.98% 86.98% 0.00%
✅ Passing 5564 5564 0
❌ Failing 833 833 0
🔶 Ignored 0 0 0
Total Tests 6397 6397 0

Number passing in both: 5564

Number failing in both: 833

Number passing in Base (75ffa06) but now fail: 0

Number failing in Base (75ffa06) but now pass: 0

@jpschorr jpschorr requested review from alancai98 and am357 and removed request for alancai98 November 16, 2024 00:39
@jpschorr jpschorr marked this pull request as ready for review November 16, 2024 00:39
@jpschorr
Copy link
Contributor Author

Follow-up #518 to fix the cargo-deny failure.

@jpschorr jpschorr merged commit 73fd2cd into dev-ion-doc Nov 18, 2024
17 of 19 checks passed
@jpschorr jpschorr deleted the feat-ast-literals branch November 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants