-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type to ast::Lit::EmbeddedDocLit
#525
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 80.75% 80.65% -0.11%
==========================================
Files 89 89
Lines 19593 19618 +25
Branches 19593 19618 +25
==========================================
Hits 15822 15822
- Misses 3352 3377 +25
Partials 419 419 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5587 Number failing in both: 842 Number passing in Base (d07a7e1) but now fail: 0 Number failing in Base (d07a7e1) but now pass: 0 |
@@ -1922,7 +1922,7 @@ fn lit_to_lit(lit: &Lit) -> Result<logical::Lit, AstTransformError> { | |||
Lit::FloatLit(f) => logical::Lit::Double(OrderedFloat::from(*f as f64)), | |||
Lit::DoubleLit(f) => logical::Lit::Double(OrderedFloat::from(*f)), | |||
Lit::BoolLit(b) => logical::Lit::Bool(*b), | |||
Lit::EmbeddedDocLit(s) => { | |||
Lit::EmbeddedDocLit(s, _) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the type argument be used in the following line rather than the hard-coded Ion
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, but there's not enough in place to do so meaningfully in the PR. This will be the extension mechanism for boxed documents. For now, only Ion is supported.
2a6442d
to
f52536a
Compare
f52536a
to
4de6533
Compare
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.