Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to ast::Lit::EmbeddedDocLit #525

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Dec 5, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr marked this pull request as ready for review December 5, 2024 22:04
@jpschorr jpschorr requested review from alancai98 and am357 December 5, 2024 22:04
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (d07a7e1) to head (4de6533).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
partiql-ast/src/pretty.rs 3.70% 26 Missing ⚠️
...sion/partiql-extension-visualize/src/ast_to_dot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   80.75%   80.65%   -0.11%     
==========================================
  Files          89       89              
  Lines       19593    19618      +25     
  Branches    19593    19618      +25     
==========================================
  Hits        15822    15822              
- Misses       3352     3377      +25     
  Partials      419      419              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2024

Conformance comparison report

Base (d07a7e1) a310ffa +/-
% Passing 86.90% 86.90% 0.00%
✅ Passing 5587 5587 0
❌ Failing 842 842 0
🔶 Ignored 0 0 0
Total Tests 6429 6429 0

Number passing in both: 5587

Number failing in both: 842

Number passing in Base (d07a7e1) but now fail: 0

Number failing in Base (d07a7e1) but now pass: 0

Base automatically changed from feat-bind-own to main December 5, 2024 22:20
partiql-ast/src/pretty.rs Outdated Show resolved Hide resolved
@@ -1922,7 +1922,7 @@ fn lit_to_lit(lit: &Lit) -> Result<logical::Lit, AstTransformError> {
Lit::FloatLit(f) => logical::Lit::Double(OrderedFloat::from(*f as f64)),
Lit::DoubleLit(f) => logical::Lit::Double(OrderedFloat::from(*f)),
Lit::BoolLit(b) => logical::Lit::Bool(*b),
Lit::EmbeddedDocLit(s) => {
Lit::EmbeddedDocLit(s, _) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the type argument be used in the following line rather than the hard-coded Ion?

Copy link
Contributor Author

@jpschorr jpschorr Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, but there's not enough in place to do so meaningfully in the PR. This will be the extension mechanism for boxed documents. For now, only Ion is supported.

partiql-ast/src/pretty.rs Outdated Show resolved Hide resolved
@jpschorr jpschorr force-pushed the feat-embedded-doc-lit-type branch from 2a6442d to f52536a Compare December 5, 2024 23:36
@jpschorr jpschorr force-pushed the feat-embedded-doc-lit-type branch from f52536a to 4de6533 Compare December 5, 2024 23:49
@jpschorr jpschorr requested a review from alancai98 December 5, 2024 23:52
@jpschorr jpschorr merged commit 27d90d1 into main Dec 5, 2024
18 of 19 checks passed
@jpschorr jpschorr deleted the feat-embedded-doc-lit-type branch December 5, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants