On the road to simpler components & better dev experience

[xavxyz]

🚧 ➡️ 🛣 work in progress pull request

State of the art, summer 2016 🚀

The project is developed in 24 hours: the React components are working, though it takes time to read through them / make a modification (ex: jQuery was actually used somewhere, at some point, to clean :empty DOM 🛩 🌮)

Pimped components ✨

This PR intends to:

• provide a better dev experience thanks to a component explorer (Storybook) and tests (snapshot testing with Jest);
• components easier to read, manage and update by tending toward functional components (recompose ftw) and using of CSS-in-JS (styled-components).

What's going on now? 🛠

• Setup Storybook with mocked data apollo-test-utils
  • it's working!
  • uncertainty: are there better way to mock data than the way I did?
• Setup snapshots testing thanks to Storyshots
  • it's working however...
  • I need to use a local addDecorator cause of .addDecorator is probably not working storybook-eol/storyshots#68 (will find time to fix this problem there)
  • I'm not using jest-transform-graphql, it's obsolete (screenshot of the bug). I rolled my own (~fork), I don't believe I'm using the graphql-tag/loader the right way (RecentTours snapshots are displaying "Loading..." 👎 a77f2b0#diff-c2bc02f8e206c05e949653f49305bf42).
• And of course, write useful stories helping understand the app and refactor the components
  • TourBadge is used in RecentTours & Tour 🤓
  • still a lot to do there 👍

Note: I've hit (and solved/got around) quiet a few walls while setting up the tooling, happy to talk about the decision taken. And happy to talk about the components refactoring / styling / direction of the project 🙂

[xavxyz]

I'm closing this, I'm working on something really simpler (lol) and with a better user experience

Sneak peek: