Fix incorrect result when an empty bitset intersects with itself

pascal-lab · Sep 21, 2024 · 7411dda · 7411dda
1 parent b503389
commit 7411dda
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/main/java/pascal/taie/util/collection/RegularBitSet.java b/src/main/java/pascal/taie/util/collection/RegularBitSet.java
@@ -312,6 +312,9 @@ public int previousClearBit(int fromIndex) {
 
     @Override
     public boolean intersects(IBitSet set) {
+        if (this.isEmpty() || set.isEmpty()) {
+            return false;
+        }
         if (this == set) {
             return true;
         }

diff --git a/src/main/java/pascal/taie/util/collection/SparseBitSet.java b/src/main/java/pascal/taie/util/collection/SparseBitSet.java
@@ -482,6 +482,9 @@ public int previousClearBit(int fromIndex) {
 
     @Override
     public boolean intersects(IBitSet set) {
+        if (this.isEmpty() || set.isEmpty()) {
+            return false;
+        }
         if (this == set) {
             return true;
         }

diff --git a/src/test/java/pascal/taie/util/collection/IBitSetTest.java b/src/test/java/pascal/taie/util/collection/IBitSetTest.java
@@ -73,8 +73,10 @@ void testClear() {
     @Test
     void testIntersects() {
         IBitSet s1 = of();
+        assertFalse(s1.intersects(s1));
         IBitSet s2 = of();
         assertFalse(s1.intersects(s2));
+        assertFalse(s2.intersects(s1));
         s2 = of(1, 233, 666);
         assertFalse(s1.intersects(s2));
         assertFalse(s2.intersects(s1));
@@ -83,6 +85,7 @@ void testIntersects() {
         assertTrue(s2.intersects(s1));
         s1.clear(666);
         assertFalse(s1.intersects(s2));
+        assertFalse(s2.intersects(s1));
     }
 
     @Test