-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete tests #13
base: master
Are you sure you want to change the base?
complete tests #13
Conversation
# This file is for unifying the coding style for different editors and IDEs | ||
# editorconfig.org | ||
|
||
root = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this file please? Or even better, add it to the .gitignore file?
Although this is nice of course, it is very specific for a (set of) editors, whilst ignoring others. Next to that, I'd much rather have these rules enforced with something like grumphp and php-cf-fixer, so it doesn't matter which editor people use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. It can use the php-cs-fixer
or StyleCI and let the command be the Composer script in composer.json
.
Would you prefer which one to replace the .editorconfig
?
Thanks.
Thanks for the test additions, good spot with the phpunit upgrade. |
Yes. The coverage numbers for someone that it's not the preference. |
Changed log
count
function problem for PHP version7.2
.This is the Travis build log before updating the PHPUnit version.
And here is the new Travis build log after using the PHPUnit version 6.5+.
Here is the code coverage report generated by coveralls.