Handle workflow_dispatch as intended #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskfung
commented
Sep 19, 2020
README.md
Outdated
| * `status` | ||
| * `workflow_dispatch` | ||
|
|
||
| For more information on when these occur, see the Github documentation on [Webhook events and payloads](https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads). |
There was a problem hiding this comment.
As a user, I didn't really know when each of these referenced events occurred.
As a contributor, I wanted to see the corresponding payloads.
Hope this helps people down the line.
pascalgn
reviewed
Sep 24, 2020
|
@pascalgn anything else I can handle on this branch? |
|
Thanks for the nice PR, it's merged now! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Follow-up to #107)
🤦 In my original PR I grossly misunderstood what
handleBranchUpdatewas doing. The intended experience was this:Here is a way to reuse some existing parts to achieve this.